Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.ocamlformat-mlx: init at 0.26.2.0 #367235

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

Denommus
Copy link
Contributor

ocamlformat-mlx is a fork of ocamlformat to format .mlx files (OCaml files with jsx-like syntax). I'm doing it in a different directory from ocamlformat altogether because it has both a different versioning system and a different src from ocamlformat, so I didn't see a reason to try to adapt it to the generic.nix file in ocamlformat.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 21, 2024
Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. I would just rename the files lib.nix and default.nix to match the convention in the other packages.

@Denommus
Copy link
Contributor Author

@anmonteiro I'm following the naming convention of ocamlformat

@lucasew lucasew requested a review from thiagokokada December 22, 2024 23:10
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@Denommus
Copy link
Contributor Author

@anmonteiro I did what you suggested

@lucasew
Copy link
Contributor

lucasew commented Dec 25, 2024

I guess ill have to add --eval local in default workflow args
Screenshot_20241225-203406

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 26, 2024
@Denommus
Copy link
Contributor Author

@ulrikstrid done

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367235

2 similar comments
@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367235

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367235

@thiagokokada thiagokokada merged commit 581fd65 into NixOS:master Dec 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants