-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.ocamlformat-mlx: init at 0.26.2.0 #367235
Conversation
2725316
to
d1f4aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. I would just rename the files lib.nix
and default.nix
to match the convention in the other packages.
@anmonteiro I'm following the naming convention of ocamlformat |
d1f4aed
to
72a0955
Compare
72a0955
to
5aa7ec7
Compare
@anmonteiro I did what you suggested |
5aa7ec7
to
d9bea2b
Compare
d9bea2b
to
b6b5ced
Compare
@ulrikstrid done |
|
2 similar comments
|
|
ocamlformat-mlx is a fork of ocamlformat to format .mlx files (OCaml files with jsx-like syntax). I'm doing it in a different directory from ocamlformat altogether because it has both a different versioning system and a different src from ocamlformat, so I didn't see a reason to try to adapt it to the
generic.nix
file in ocamlformat.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.